Skip to content

Add module interfaces to the set of module provided entities#487

Merged
arporter merged 3 commits intostfc:masterfrom
nmnobre:module
Dec 15, 2025
Merged

Add module interfaces to the set of module provided entities#487
arporter merged 3 commits intostfc:masterfrom
nmnobre:module

Conversation

@nmnobre
Copy link
Member

@nmnobre nmnobre commented Oct 30, 2025

No description provided.

@codecov
Copy link

codecov bot commented Oct 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.19%. Comparing base (044f28d) to head (c2235b1).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #487   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files          86       86           
  Lines       13806    13807    +1     
=======================================
+ Hits        12729    12730    +1     
  Misses       1077     1077

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso
Copy link
Collaborator

sergisiso commented Nov 3, 2025

@arporter This touches fparser1 which I am not familiar with, so I will leave the review to you.

For context, this is to prevent the

Traceback (most recent call last):
  File "/archive/psyclone-tests/action-runner-software/actions-runner/_work/PSyclone-mirror/PSyclone-mirror/.runner_venv/lib/python3.14/site-packages/fparser/common/utils.py", line 330, in new_func
    func(self)
    ~~~~^^^^^^
  File "/archive/psyclone-tests/action-runner-software/actions-runner/_work/PSyclone-mirror/PSyclone-mirror/.runner_venv/lib/python3.14/site-packages/fparser/one/statements.py", line 1354, in analyze
    self.populate_use_provides(all_mod_provides, use_provides, name)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/archive/psyclone-tests/action-runner-software/actions-runner/_work/PSyclone-mirror/PSyclone-mirror/.runner_venv/lib/python3.14/site-packages/fparser/one/statements.py", line 1375, in populate_use_provides
    raise AnalyzeError(
        "entity name '%s' is not in module '%s'" % (name, self.name)
    )
fparser.common.utils.AnalyzeError: entity name 'dummy_code' is not in module 'dummy_mod'

That psyclone sometimes produces but ignores.

Updating the kernel metadata parsing to use fparser2 would also bypass this (and allow us to deprecate fparser1), but the task is currenlty not in any funded project.

@sergisiso sergisiso requested a review from arporter November 3, 2025 15:24
arporter
arporter approved these changes Dec 15, 2025
View reviewed changes
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I'd request an associated test but, since fparser1 is deprecated, I'll skip that.
I've tested PSyclone with this version of fparser and the test suite was fine.

@arporter arporter merged commit 883f296 into stfc:master Dec 15, 2025
6 checks passed
@nmnobre nmnobre deleted the module branch December 15, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arporter arporter arporter approved these changes

Assignees

No one assigned

Labels

under review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nmnobre @sergisiso @arporter